Application Development Discussions
Join the discussions or start your own on all things application development, including tools and APIs, programming models, and keeping your skills sharp.
cancel
Turn on suggestions
Auto-suggest helps you quickly narrow down your search results by suggesting possible matches as you type.
Showing results for 
Search instead for 
Did you mean: 

performance

raj_sahay
Explorer

‎10-17-2007 9:36 AM

0 Kudos

Hi

This is a piece of code . can anyone suggest me how to increase the performance . ,

tx

LOOP AT WERTETAB .

CLEAR : FLAG , FLAG1 .

MOVE-CORRESPONDING WERTETAB TO IT_FINAL .

SHIFT IT_FINAL-MATNR LEFT DELETING LEADING '0' .

IT_FINAL-SLEVEL = WERTETAB-AKT_MENGE .

****For stock level

  • Select single lbkum into IT_FINAL-SLEVEL from mbew

  • where matnr = wertetab-matnr and bwkey = wertetab-werks .

.

***For Total stock value

SELECT SUM( WBWBEST ) INTO IT_FINAL-SVALUE FROM S032

WHERE MATNR EQ

WERTETAB-MATNR

AND WERKS EQ

WERTETAB-WERKS.

*****For Total No of Usages

SELECT SUM( AGVBR ) FROM S033 INTO IT_FINAL-AGVBR

WHERE MATNR EQ WERTETAB-MATNR

AND WERKS EQ WERTETAB-WERKS

AND SPTAG IN S_DATE .

****

LOOP AT MSEG101 WHERE MATNR = WERTETAB-MATNR

AND WERKS = WERTETAB-WERKS .

  • IT_FINAL-BWART = MSEG101-BWART .

  • IT_FINAL-LGORT = MSEG101-LGORT .

IT_FINAL-LRDATE = MSEG101-BUDAT.

IT_FINAL-LRQTY = MSEG101-MENGE.

PERFORM REQ_USG .

  • APPEND IT_FINAL .

  • CLEAR : IT_FINAL-LRDATE , IT_FINAL-LRQTY, IT_FINAL-AFNAM ,

  • it_final-agvbr, IT_FINAL-BWART , IT_FINAL-LGORT,MSEG101 .

EXIT .

ENDLOOP .

LOOP AT MSEG201 WHERE MATNR = WERTETAB-MATNR

AND WERKS = WERTETAB-WERKS .

*clear : IT_FINAL-SLEVEL , IT_FINAL-SVALUE.

    • IT_FINAL-BWART = MSEG201-BWART .

  • IT_FINAL-LGORT = MSEG201-LGORT .

IT_FINAL-LIDATE = MSEG201-BUDAT.

IT_FINAL-LIQTY = MSEG201-MENGE .

IF FLAG NE 'X' .

PERFORM REQ_USG1 .

ENDIF.

  • APPEND IT_FINAL .

  • CLEAR : IT_FINAL-LIDATE , IT_FINAL-LIQTY,

  • IT_FINAL-AFNAM , it_final-agvbr,

*IT_FINAL-BWART,IT_FINAL-LGORT ,MSEG201.

EXIT .

ENDLOOP .

1 REPLY 1

Former Member

‎10-19-2007 2:03 AM

0 Kudos

One quick suggestion - with your database selects, try to include a lot more of the primary key otherwise performace will suffer e.g. with S032 see if you can provide values for SSOUR, VRSIO, and LGORT (and have your "where" in the order of the primaty key - it sometimes helps).

Jonathan

p.s. also with the "shift left", I suggest you use the CONVERSION_EXIT_MATN1_INPUT function to ensure you get the correct format.